Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldAttributes as descriptors #73908

Merged
merged 6 commits into from
Jun 29, 2022
Merged

FieldAttributes as descriptors #73908

merged 6 commits into from
Jun 29, 2022

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Mar 15, 2021 •
edited

SUMMARY

FieldAttributes as descriptors

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

many

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.11 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 15, 2021
@ansibot

This comment has been minimized.

Sign in to view
@bcoca
Copy link
Member

bcoca commented Mar 15, 2021

  • I would make 'inherit' the default behaviour and 'noninheritable' the special case
  • connection i'm solving a different way and you should not need to special case anymore

@mkrizek
Copy link
Contributor Author

mkrizek commented Mar 15, 2021

  • I would make 'inherit' the default behaviour and 'noninheritable' the special case

I was thinking the same, the only reason I have it this way for now is that I didn't know how to name the noninharitable :-)

  • connection i'm solving a different way and you should not need to special case anymore

+1

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Mar 16, 2021
@ansibot

This comment has been minimized.

Sign in to view
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 16, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 17, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 26, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Apr 12, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 21, 2021
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 1, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 9, 2021
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 10, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 6, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 14, 2022
bcoca
bcoca reviewed Jun 14, 2022
View reviewed changes
lib/ansible/playbook/base.py
become_method = FieldAttribute(isa='string', default=context.cliargs_deferred_get('become_method'))
become_user = FieldAttribute(isa='string', default=context.cliargs_deferred_get('become_user'))
become_flags = FieldAttribute(isa='string', default=context.cliargs_deferred_get('become_flags'))
become_exe = FieldAttribute(isa='string', default=context.cliargs_deferred_get('become_exe'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but 'cliargs_deffered_get' paths could be simplified by just setting it as part of inheritance in the run, default hte 'top object' (currently play, but could be 'playbook') to the cli/config/env var values.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 16, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 29, 2022
@mkrizek
Copy link
Contributor Author

mkrizek commented Jun 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkrizek mkrizek merged commit 43153c5 into ansible:devel Jun 29, 2022
ansible-core 2.14 automation moved this from In Progress to Done Jun 29, 2022
@mkrizek mkrizek deleted the field-descriptors branch June 29, 2022 12:39
@mkrizek mkrizek mentioned this pull request Jul 1, 2022
Merged
@ansible ansible locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel left review comments

@bcoca bcoca bcoca approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
ansible-core 2.14
Status: Done
ansible-core 2.14
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkrizek @ansibot @bcoca @sivel @s-hertel